This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Remove Fastify and web server #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
approved these changes
Mar 24, 2021
|
We haven't moved far with developments around this, but I'd keep it in for longer. At least until we get to do a proof of concept of running the plugin server inside the web dyno in heroku and seeing if we can get some communication between them. |
This was referenced May 27, 2021
|
Superseded by #439. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've realized it's not feasible to run a plugin web server due to the limitations of Heroku (which is an important deployment platform for us): https://github.com/PostHog/plugin-server/issues/165#issuecomment-805759098
Therefore this PR removes the Fastify web server that has been dead code for a while.
Closes #25.
Checklist